Skip to content

Clean up and add tests for new lookup code parameter handling #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Jun 24, 2021

Some leftovers from before I implemented field formal parameters were causing failures in some cases for Flutter. Fix that, get rid of another generator that is causing debugging problems, and add tests.

166 flutter unresolved doc references -> 77 with this change.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 24, 2021
@jcollins-g jcollins-g requested a review from devoncarew June 24, 2021 20:02
@jcollins-g jcollins-g marked this pull request as ready for review June 24, 2021 20:02
@jcollins-g jcollins-g merged commit 9e5fd51 into dart-lang:master Jun 24, 2021
@jcollins-g jcollins-g deleted the parameter-handling-redux branch June 24, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants