Move ToolDefinition and related classes out of dartdoc_options #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolDefinition, DartToolDefinition, Snapshot, and SnapshotCache (~250 lines) are all only lightly related to dartdoc options. These four classes are easily extracted to their own file.
This change also replaces the Tuple2 usage with ToolStateForArgs, and refactors
modifyArgsToCreateSnapshotIfNeededto a new method which exists on both ToolDefinition and on DartToolDefinition.These changes will help a new change to fix #2344 by emitting a warning from the new file.