Skip to content

Add package global and graph global lookups to new lookup code #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 16, 2021

Conversation

jcollins-g
Copy link
Contributor

This is a batch of changes centered around implementing the new package-global lookups.

  • Corrects a parser problem where we were greedily eating const and other prefixes from the names of variables during lookup
  • Adds global lookups and packageGlobal lookups
  • Filed disallow referring to members of a prefixed library that are hidden #2683 to address users depending on prefix lookups being excessively forgiving
  • Fixes an accounting problem in the checker where we were comparing accessors and their enclosingCombos as different -- this isn't true in practice.
  • Do not accidentally pick up parameters of the default constructor.

This advances Flutter compliance a few percent to 77% -- biggest issues now are scoping problems around inherited documentation.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 15, 2021
@jcollins-g jcollins-g requested a review from srawlins June 15, 2021 23:00
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 57.781% when pulling 13ddc73 on jcollins-g:package-globals into 9ef58f2 on dart-lang:master.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Lots. of. tests.

@jcollins-g jcollins-g merged commit 99f45ab into dart-lang:master Jun 16, 2021
@jcollins-g jcollins-g deleted the package-globals branch June 16, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants