Implement this, operator, and parameter resolution on Containers #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Jun 10, 2021
|
|
||
| class StringTrie { | ||
| final Map<int, StringTrie> children = {}; | ||
| bool valid = false; |
There was a problem hiding this comment.
Would you mind documenting this field? I think I know what it means, but maybe not in the context of a field on a whole trie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. We can't directly use Scope and analyzer resolution here without some more digging into the analyzer, but we can bring the current implementation up to speed.
Link resolution equivalence moves from 98% => 99% on the SDK, 72% => 73% on Flutter. While the link resolution equivalence delta is small, the link resolution equivalence doesn't account for parameters not being found at all. That would have led to many false positives.