Report errors on SimpleRenderer on missing getters #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Jun 8, 2021
lib/src/mustachio/renderer_base.dart
Outdated
| var type = context.runtimeType; | ||
| throw MustachioResolutionError(node.keySpan.message( | ||
| '$firstName is a getter on $type, which is not visible to Mustache. ' | ||
| 'To render $firstName on $type, make it visible to mustache; to ' |
There was a problem hiding this comment.
might be more specific to help with maintenance, e.g. add to visibleTypes
lib/src/mustachio/renderer_base.dart
Outdated
|
|
||
| if (this is SimpleRenderer && _invisibleGetters.contains(names.first)) { | ||
| var type = context.runtimeType; | ||
| throw MustachioResolutionError(node.keySpan.message( |
There was a problem hiding this comment.
optional: This seems like it should work, but there is no end to end test?
There was a problem hiding this comment.
OK, there were definitely bugs :P added two tests after fixing the bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2667
If Mustachio is resolving a key and it finds a SimpleResolver (a resolver for a type not visible to Mustachio), and the key is a getter on that type, then Mustachio will throw an error rather than continue to other types up the stack.