Skip to content

Refactor lib/dartdoc.dart and dartdoc_test.dart #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2021
Merged

Refactor lib/dartdoc.dart and dartdoc_test.dart #2669

merged 2 commits into from
Jun 7, 2021

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Jun 7, 2021

I was poking around these files and noticed a few things I could tidy up:

  • DartdocFileWriter.outputDir can be private.
  • Dartdoc.writtenFiles, Dartdoc.outputDir, Dartdoc.validateLinks can be private.
  • generateDocsBase is only used in tests; mark is used as @visibleForTesting and move its dartdoc.
  • There were two ResourceProviders in the test, among some other unused elements.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 7, 2021
jcollins-g
jcollins-g approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, and as far as I can tell these aren't used by the pub site, great!

@srawlins srawlins merged commit b6fe5dd into dart-lang:master Jun 7, 2021
@srawlins srawlins deleted the refactor-dartdoc_test branch June 7, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @jcollins-g