Skip to content

Print version information when an exception is encountered #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

jcollins-g
Copy link
Contributor

Fixes #2594 by making sure it is extremely clear what version of dartdoc is reporting the error. Given that there are multiple ways to access the package for now, this should reduce confusion.

example (with a hand-added exception):

jcollins-macbookpro2:dartdoc jcollins$ dart bin/dartdoc.dart
Documenting dartdoc...
-
dartdoc 0.42.0 (/Users/jcollins/dart/dartdoc/bin/dartdoc.dart) failed: Exception
#0      PackageGraph.addLibraryToGraph (package:dartdoc/src/model/package_graph.dart:56:5)
#1      PubPackageBuilder._parseLibraries (package:dartdoc/src/model/package_builder.dart:224:23)
<asynchronous suspension>
#2      PubPackageBuilder.getLibraries (package:dartdoc/src/model/package_builder.dart:403:5)
<asynchronous suspension>
#3      PubPackageBuilder.buildPackageGraph (package:dartdoc/src/model/package_builder.dart:71:5)
<asynchronous suspension>
#4      Dartdoc.generateDocsBase (package:dartdoc/dartdoc.dart:176:20)
<asynchronous suspension>
#5      Dartdoc.generateDocs (package:dartdoc/dartdoc.dart:217:28)
<asynchronous suspension>
#6      Dartdoc.executeGuarded.<anonymous closure> (package:dartdoc/dartdoc.dart:481:9)
<asynchronous suspension>

@jcollins-g jcollins-g requested a review from srawlins April 7, 2021 16:42
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@jcollins-g jcollins-g merged commit 5c1900d into dart-lang:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dartdoc failed: NoSuchMethodError: The getter 'element' was called on null
3 participants