Adjust hierarchy for correct usage in mustache. #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare that Container mixes in TypeParameters, as the two classes which extend Container each already mix it in, and _head.html relies on a Container having a `hasGenericParameters` getter. Additional minor changes to Category for debugging, and for use in templates.
* `navLinksWithGenerics` must contain Containers, so that fields like `hasGenericParameters` are statically available. * TemplateData must have a `homepage` field as it is referenced in `_search_sidebar` template, so it must always be available.
jcollins-g
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare that Container mixes in TypeParameters, as the two classes which extend
Container each already mix it in, and _head.html relies on a Container having a
hasGenericParametersgetter.Additional minor changes to Category for debugging, and for use in templates.