Skip to content

Add a nodoc configuration option to allow declaring entire files to not be documented #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 5, 2020

Conversation

jcollins-g
Copy link
Contributor

Fixes #2266 and I think, #2355.

This adds an option to dartdoc_options.yaml to dynamically tag code with @nodoc based on whether it matches the given globs. See README.md and/or the test package for usage information.

Note that this tags objects declared in the given files. Objects reexported or visible via inheritance only through files matching the glob will not be affected (though, they won't be documented as part of that library since that library won't be documented). Reexporting something declared in files matching the globs won't remove this virtual @nodoc, differing this config option from the behavior of exclude.

It directly addresses @timsneath's issue in #2266 and I think may solve #2355 as well. If this isn't fine-grained enough for the use case in #2355 it might need a follow-up at some point.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 1, 2020
@jcollins-g jcollins-g mentioned this pull request Oct 1, 2020
@jcollins-g
Copy link
Contributor Author

jcollins-g commented Oct 2, 2020

i will need to poke at this a bit to correct lingering path issues. The draft should work fine on Linux/Mac though.

@coveralls
Copy link

coveralls commented Oct 2, 2020

Coverage Status

Coverage decreased (-0.02%) to 91.668% when pulling cbc7b74 on nodoc-param into db8f78f on master.

@jcollins-g jcollins-g marked this pull request as ready for review October 5, 2020 16:58
@jcollins-g jcollins-g requested a review from srawlins October 5, 2020 16:58
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@jcollins-g jcollins-g merged commit a0cc2dc into master Oct 5, 2020
@timsneath
Copy link

FANTASTIC! Thank you both!

@jcollins-g jcollins-g deleted the nodoc-param branch August 11, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dartdoc should allow file-level attributes
5 participants