Skip to content

Fix implementation chain with internal private classes #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

srawlins
Copy link
Member

Fixes #2290

Before this fix, RestorableValue lists no implementors. After this fix, RestorableValue lists the following implementors:

RestorableBool, RestorableNum, RestorableString

Fixes #2094

Before this fix, DiagnosticsProperty lists the following implementors:

ColorProperty, DiagnosticsDebugCreator, EnumProperty, ErrorSpacer, FlagProperty, FlagsSummary, IconDataProperty, IterableProperty, MessageProperty, ObjectFlagProperty, ShortcutMapProperty, StringProperty, TransformProperty

After this fix, DiagnosticsProperty lists the following implementors:

ErrorDescription, ErrorHint, ErrorSummary, DoubleProperty, IntProperty, ColorProperty, DiagnosticsDebugCreator, EnumProperty, ErrorSpacer, FlagProperty, FlagsSummary, IconDataProperty, IterableProperty, MessageProperty, ObjectFlagProperty, ShortcutMapProperty, StringProperty, TransformProperty

@srawlins srawlins requested a review from jcollins-g September 23, 2020 20:41
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Sep 23, 2020
@srawlins srawlins merged commit 9b932a2 into dart-lang:master Sep 25, 2020
@srawlins srawlins deleted the private-implementors branch September 25, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
3 participants