Refactor shared code in tests and tools. #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move SubprocessLauncher out of test/, into tool/. It's imported by both. * Move most top-level Directory objects out of utils.dart, into singular test files where they are used, mostly dartdoc_test.dart. * Move `generatorContextFromArgv` from utils.dart to dartdoc_test.dart. * Clean up set-up and tear-down methods in dartdoc_test.dart. * Move most top-level PackageGraph code from utils.dart to model_special_cases_test.dart and model_test.dart. Also type-annotate public API in warnings.dart.
scheglov
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files where they are used, mostly dartdoc_test.dart.
generatorContextFromArgvfrom utils.dart to dartdoc_test.dart.model_special_cases_test.dart and model_test.dart.
Also type-annotate public API in warnings.dart.