Skip to content

Use &lt; instead of < in markdown #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

rokob
Copy link
Contributor

@rokob rokob commented Jun 24, 2020

There are several places in the generated markdown where generics get rendered with . This changes those to instead use <types>. Some markdown renderers don't like because it looks like embedded html.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jun 24, 2020
@mehmetf
Copy link
Contributor

mehmetf commented Jun 24, 2020

Should the > be changed to &gt; for symmetry? :)

@mehmetf mehmetf requested a review from jdkoren June 24, 2020 14:53
@rokob
Copy link
Contributor Author

rokob commented Jun 24, 2020

I was coping the style of the rest of the codebase, for example #2162 only does the open bracket. You only really need to do the open bracket as the > doesn't raise any red flags to parsers. I'm happy to go either way.

@mehmetf mehmetf merged commit c7c25be into dart-lang:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants