Remove driver and session from PackageGraph #2204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I would like to remove the presence of
AnalysisDriver
and Session fromPackageGraph
.Why
PackageGraph
is available to many model objects and it makes good sense to reduce the available API surface.It is preferred that
PackageBuilder
populates all necessary information for dartdoc to function during build phase rather than relying on model objects to lazily get them fromAnalysisSession
. This allows us to handle situations where anAnalysisSession
is not available such as constructing ResolvedLibrary objects from summary data.