Skip to content

Remove driver and session from PackageGraph #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2020

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented May 7, 2020

What
I would like to remove the presence of AnalysisDriver and Session from PackageGraph.

Why
PackageGraph is available to many model objects and it makes good sense to reduce the available API surface.

It is preferred that PackageBuilder populates all necessary information for dartdoc to function during build phase rather than relying on model objects to lazily get them from AnalysisSession. This allows us to handle situations where an AnalysisSession is not available such as constructing ResolvedLibrary objects from summary data.

@mehmetf mehmetf requested a review from jcollins-g May 7, 2020 23:51
@googlebot googlebot added the cla: yes Google CLA check succeeded. label May 7, 2020
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is going in the general direction dartdoc has been moving for a while. Originally, all elements were lazily fetched and the fact we still have some support for that is vestigal at this point. Thanks for the cleanup!

@mehmetf mehmetf merged commit 1196ef0 into dart-lang:master May 9, 2020
@mehmetf mehmetf deleted the remove_driver branch May 9, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants