Skip to content

Correct invalid member linkage #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Correct invalid member linkage #2191

merged 2 commits into from
Apr 24, 2020

Conversation

jcollins-g
Copy link
Contributor

Fixes #2008.

Dartdoc forgot to consider the explicitly specified class name, if available, when matching members in comment references. This fixes that, and adds a test.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 23, 2020
@jcollins-g jcollins-g changed the title Invalid constructor link Correct invalid member linkage Apr 23, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 91.629% when pulling c236f13 on invalid-constructor-link into 18fdf4a on master.

@jcollins-g jcollins-g merged commit 9625d07 into master Apr 24, 2020
@jcollins-g jcollins-g deleted the invalid-constructor-link branch April 27, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract factory not linked
4 participants