Skip to content

Create some initial templates for md #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2020
Merged

Create some initial templates for md #2145

merged 3 commits into from
Feb 25, 2020

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Feb 12, 2020 •
edited
Loading

These are very likely most definitely not perfect, but gets us moving on wiring together a backend for them. They are currently not loaded yet as --format md still uses the EmptyGenerator.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Feb 12, 2020
@jdkoren jdkoren requested a review from jcollins-g February 12, 2020 20:28
jcollins-g
jcollins-g approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a problem with this as written, but it's going to be challenging to know what's potentially wrong until more gets wired up and we can look at some sample output as you suggest in the PR. Approved.

@jdkoren jdkoren merged commit bf9f568 into dart-lang:master Feb 25, 2020
@jdkoren
Copy link
Contributor Author

jdkoren commented Feb 25, 2020

I don't see a problem with this as written, but it's going to be challenging to know what's potentially wrong until more gets wired up and we can look at some sample output as you suggest in the PR. Approved.

It's mainly just to have a place for the fields to go. I expect the first round of actual output will look really bad 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdkoren @jcollins-g @googlebot