Use template comment syntax for header & footer placeholders #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Jan 22, 2020
| const String _headerPlaceholder = '<!-- header placeholder -->'; | ||
| const String _footerPlaceholder = '<!-- footer placeholder -->'; | ||
| const String _footerTextPlaceholder = '<!-- footer-text placeholder -->'; | ||
| const String _headerPlaceholder = '{{! header placeholder }}'; |
There was a problem hiding this comment.
Might be worth a TODO for replacePlaceholder to port these to mustache rather than using our own template substitutions. A typo in the template would be less easy to miss that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different formats have different comment syntax, so use template comment syntax for these placeholders instead of html syntax. If no content is passed to replace them, the placeholders will not appear in the output files.