Determine file extensions on a per-package basis #2134
Conversation
|
I just realized something -- that with --link-to-remote we're making an implicit assumption about how other packages are rendered and that it is the same as what we're rendering locally. That should be possible to fix by adding some data to the table that knows how to link to remote packages. That might influence how we decide to determine the extension -- perhaps, it should be owned by the |
jdkoren
force-pushed
the
filename_renderer
branch
from
e1d689d to
8ae0871
Compare
|
Changed so that Also rebased. |
lib/src/model/package.dart
Outdated
| if (package.documentedWhere == DocumentLocation.remote) { | ||
| return 'html'; | ||
| } | ||
| return packageGraph.rendererFactory.fileTypeRenderer.fileType; |
There was a problem hiding this comment.
I'm contemplating using the config member to lookup the format instead of using a renderer here. That requires moving format out of GeneratorContext and into DartdocOptionContext.
There was a problem hiding this comment.
Hmm. It's not immediately clear to me which is preferable, but a config member would be the most direct way to get this information. I'm OK with either choice.
There was a problem hiding this comment.
Switched to using the config member as it's a bit more direct.
jdkoren
changed the title
We need a way to change extensions for generated files. Some considerations:
Generators can emit additional files, so having the generator apply/change file extensions for everything isn't ideal. We can store something in the
PackageGraphand look it up in our models, but polluting that class is a bit of a code smell--however, we do that already for the RendererFactory, so I opted to use that existing pattern for this purpose. Happy to explore alternatives.