Skip to content

Revert "Revert "Refactor html generator into frontend and backend"" #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Revert "Revert "Refactor html generator into frontend and backend"" #2121

merged 1 commit into from
Jan 16, 2020

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Jan 9, 2020

Reverts #2120

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 9, 2020
@jdkoren jdkoren requested a review from jcollins-g January 9, 2020 21:22
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 93.891% when pulling 76749e9 on revert-2120-revert-2115-html_backend into 0cbefb9 on master.

jcollins-g
jcollins-g approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved; but let's delay merging until post 0.30.0 chaos has settled somewhat.

@jcollins-g
Copy link
Contributor

I'm going to need a full test cycle before the next release anyhow; you're clear to land.

@jdkoren jdkoren merged commit 8e9ed19 into master Jan 16, 2020
@kevmoo kevmoo deleted the revert-2120-revert-2115-html_backend branch May 21, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdkoren @coveralls @jcollins-g @googlebot