Move generator options into generator.dart #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a second look once the base lands. My main concern here is it seems like a lot of parameters, while they theoretically could apply to different generators, will change radically in behavior (for example, the templates directory I assume might not contain HTML?). It's probably fine for now, but it'll be necessary to clarify this more once we actually have different generators. |
|
Yeah, it might not actually be necessary/worthwhile to split base vs html generator options. I'll ponder this a little more. |
jdkoren
force-pushed
the
generator_context
branch
from
9ae5bce to
4f27b8f
Compare
jdkoren
changed the title
|
Recombined the base and html options into one |
jdkoren
force-pushed
the
generator_context
branch
from
4f27b8f to
17e6db2
Compare
jcollins-g
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(on top of #2098 - compare here)
Moved options that configure the generator to
generator.dart. These can be used by more than one generator in the future.