Decouple href and from a model's filename #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkoren
changed the title
jdkoren
commented
Dec 16, 2019
lib/src/model/class.dart
Outdated
| @@ -201,6 +201,16 @@ class Class extends Container | |||
| @override | |||
| String get fileName => "${name}-class.html"; | |||
|
|
|||
| @override | |||
| String get filePath { | |||
| if (!identical(canonicalModelElement, this)) { | |||
There was a problem hiding this comment.
I basically copied href's implementation in all these files and removed the ${package.baseHref}, but I'm not sure this is the right approach.
jcollins-g
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a model's href is also used to determine the filename where Dartdoc generates documentation. This change separates the two usages so that hrefs could be relative and include parts that should not be in a file path, such a
...See #2090