Skip to content

Upgrade to analyzer 0.39.2+1 and fix using deprecated APIs. #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

scheglov
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 13, 2019
@scheglov scheglov requested a review from jcollins-g December 14, 2019 01:07

@override
Iterable<Class> get classes => allClasses.where((c) => !c.isErrorOrException);

@override
LibraryElement get element => super.element;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. though there should be no reason for the _libraryElement member at this point. Can you remove and change references?

@scheglov scheglov force-pushed the upgrade-to-analyzer-0.39.2+1 branch from d236979 to 4ed3c6a Compare December 16, 2019 17:07
@scheglov scheglov merged commit 03849e0 into dart-lang:master Dec 16, 2019
@scheglov scheglov deleted the upgrade-to-analyzer-0.39.2+1 branch December 16, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants