Don't use 'Element.type'. #2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keertip
approved these changes
Sep 25, 2019
scheglov
force-pushed
the
dont-use-Element-dot-type
branch
from
dacd797 to
8b77047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most elements
.typeshould be considered deprecated.Specifically, for
ClassElement,GenericFunctionTypeElement, andTypeParameterElement.These elements don't have external types per se, but can be used to construct a type.
Before NNBD to construct a type from them you needed to provide type arguments.
Now you need to provide type arguments, and also the nullability suffix.
I have never been fond of using raw InterfaceType(s) as workpieces for actual types.
But with NNBD this just gets out of hand, especially with type parameters.
So, it is time for a clean-up.