-
Notifications
You must be signed in to change notification settings - Fork 124
Document embedder SDK packages only when they are in the same path as the main package. #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@isoos, can you update the body of this PR w/ the issues it'll fix? |
The pedantic change has landed in master. |
@isoos, could you rebase and see if the tests pass? |
… the main package.
rebased, force pushed |
@jcollins-g @isoos is anyone looking at fixing this? I'd love to get dart-lang/pub-dev#2117 resolved. |
I am not looking at this. |
Do we have an alternate way of resolving dart-lang/pub-dev#2117 ? |
Note: The package may have changed since last May, but at that time, I tracked the root cause back to the embedder SDK-related code here (and an assumed change in Flutter which was never tracked down when it happened). I have no idea what the embedder SDK-related code is supposed to do or when it is used (or if this is the correct way of resolving the issue), and I can't even say that the PR was the correct way how to address this. |
This has been fixed elsewhere. |
Running dartdoc on Flutter packages generates docs for the SDK libraries too, and pub site wants to exclude them (pub site issue: dart-lang/pub-dev#2108 ). However using
--exclude
removes the links, e.g.Future
is not linked to the official SDK docs page.Restricting the embedder SDK to the direct subdirectories solves the issue for the Flutter packages, and also keeps the option to generate embedder SDK docs if needed.