Fix inconsistent indentation for inheritance info - Fixes #1687 #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
May 16, 2019
lib/resources/styles.css
Outdated
| @@ -563,6 +563,7 @@ footer a, footer a:hover { | |||
| background-image: none; | |||
| content: ""; | |||
| margin: 0; | |||
| padding: 0 0 0 0; | |||
There was a problem hiding this comment.
This can collapse to padding: 0;.
parlough
force-pushed
the
fix/inconsistent-indent
branch
from
26cb912 to
7b92b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes the indentation for inheritance info similar to other fields such as "Implementers" and "Mixed in types". Fixes #1687
If this is not desired design, that's fine. It just seems that elsewhere in the docs uses indentation like this sparingly, and it seems to just be because of forgetting to handle the first item in the list's padding separately.
Original:
Changed: