Skip to content

Support the latest version of pkg:html #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2019
Merged

Support the latest version of pkg:html #1953

merged 1 commit into from
Apr 9, 2019

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Apr 9, 2019

No description provided.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 9, 2019
@kevmoo kevmoo requested a review from devoncarew April 9, 2019 00:51
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 94.118% when pulling 6cfc3f2 on latest_pkg_html into baa7864 on master.

devoncarew
devoncarew approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'd thought that we checked the pubspec.lock file in for this repo, but looking at the repo source, apparently not.

@kevmoo
Copy link
Member Author

kevmoo commented Apr 9, 2019

lgtm. I'd thought that we checked the pubspec.lock file in for this repo, but looking at the repo source, apparently not.

...which for a publish package is the right thing to do!

@kevmoo kevmoo merged commit 2751ba5 into master Apr 9, 2019
@kevmoo kevmoo deleted the latest_pkg_html branch April 9, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevmoo @coveralls @devoncarew @googlebot