Skip to content

use the package:pedantic analysis options #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2019
Merged

use the package:pedantic analysis options #1951

merged 3 commits into from
Apr 9, 2019

Conversation

devoncarew
Copy link
Member

  • use the package:pedantic analysis options

@kevmoo @pq

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 5, 2019
@coveralls
Copy link

coveralls commented Apr 5, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 94.153% when pulling d609d86 on use_pedantic into 2751ba5 on master.

pq
pq approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@devoncarew
Copy link
Member Author

devoncarew commented Apr 5, 2019 •
edited
Loading

Looks like package:angular has bumped their min sdk to 2.2.1-dev.3.0 - it's what's causing our bots to fail. Also, it looks like its failing doc gen on pub.dartlang.org: https://pub.dartlang.org/packages/angular#-versions-tab-

@kevmoo
Copy link
Member

kevmoo commented Apr 5, 2019

You should be able to pin angular to the previous version – I'm surprised that version solving failed.

@kevmoo
Copy link
Member

kevmoo commented Apr 9, 2019

@devoncarew – bet if you rebase this you'll be good!

@devoncarew
Copy link
Member Author

Thanks! Updating now.

@kevmoo
Copy link
Member

kevmoo commented Apr 9, 2019

@devoncarew – I kicked travis. you're green!

@devoncarew devoncarew merged commit af7fc0e into master Apr 9, 2019
@kevmoo kevmoo deleted the use_pedantic branch April 25, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devoncarew @coveralls @kevmoo @pq @googlebot