Skip to content

Make precaching work for borrowed documentation #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2019
Merged

Make precaching work for borrowed documentation #1934

merged 2 commits into from
Feb 12, 2019

Conversation

jcollins-g
Copy link
Contributor

Fixes #1930.

By failing to traverse documentationFrom when precaching, dartdoc was accidentally dropping borrowed documentation from tool output substitution.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Feb 12, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 93.439% when pulling bef897f on fix-missing-tool-runs into 9e5a57d on master.

@jcollins-g jcollins-g merged commit d59800f into master Feb 12, 2019
@jcollins-g jcollins-g deleted the fix-missing-tool-runs branch February 12, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @gspencergoog @googlebot