Skip to content

Make experiment_options_test less fragile with respect to defaults #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2019
Merged

Make experiment_options_test less fragile with respect to defaults #1932

merged 2 commits into from
Feb 11, 2019

Conversation

jcollins-g
Copy link
Contributor

Fixes #1931 for the head analyzer (and shortly, the published version).

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Feb 11, 2019
@jcollins-g jcollins-g mentioned this pull request Feb 11, 2019
Merged
@jcollins-g jcollins-g requested review from pq and devoncarew February 11, 2019 20:00
pq
pq approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit 93e5da1 into master Feb 11, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.433% when pulling 8183a29 on fix-sdk-experiment-tests into 9eadb60 on master.

@kevmoo kevmoo deleted the fix-sdk-experiment-tests branch April 25, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

@devoncarew devoncarew Awaiting requested review from devoncarew

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @pq @googlebot