Skip to content

Fix style to avoid deprecation warning #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

Fix style to avoid deprecation warning #1919

merged 1 commit into from
Feb 1, 2019

Conversation

jcollins-g
Copy link
Contributor

Fixes #1918.

Discovered that this particular style was responsible for the warnings due to two unescaped #s. Escaping it seems to work without breaking anything -- header still looks correct on generated pages.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Feb 1, 2019
@jcollins-g jcollins-g requested a review from pq February 1, 2019 17:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.984% when pulling c90d17a on fix-deprecation-warning into 517f307 on master.

pq
pq approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit 85b3166 into master Feb 1, 2019
@jcollins-g jcollins-g deleted the fix-deprecation-warning branch February 1, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @pq @googlebot