-
Notifications
You must be signed in to change notification settings - Fork 124
Refine styles to better match current dartlang.org #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming that we are properly importing Roboto from somewhere
box-sizing: border-box; | ||
} | ||
|
||
*, *:before, *:after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems somewhat drastic to change every element to box sizing. From very brief googling (https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/) this does seem like a thing that people do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Doing this seemed to make correcting some alignment problems for mobile a lot easier.
lib/resources/styles.css
Outdated
margin-right: 20px; | ||
} | ||
/* end for layout */ | ||
|
||
body { | ||
-webkit-text-size-adjust: 100%; | ||
overflow-x: hidden; | ||
font-family: "Source Sans Pro", sans-serif; | ||
font-family: roboto, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For similarity with below, Roboto
(note the case)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we're already importing Roboto from somewhere?
I see the import of Source Code Pro and the material icons font, but not of Roboto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roboto is a builtin as discussed offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed capitalization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll probably update styles again before May, just FYI. (It never stops!)
Fixes #1372, #1911.
Resynchronize dartdoc styles with current dartlang.org and fix a number of problems. Including:
:hover
to highlight linksScreenshots (slightly larger than window to be able to compare header size)