Skip to content

Refine styles to better match current dartlang.org #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 31, 2019
Merged

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Jan 31, 2019

Fixes #1372, #1911.

Resynchronize dartdoc styles with current dartlang.org and fix a number of problems. Including:

  • Smaller fixed-height header
  • More space between main content and header
  • Larger left-side column
  • Use of Roboto font
  • Use of :hover to highlight links
  • Miscellaneous alignment tweaks
  • Match color scheme more closely with dartlang.org
  • Fix scrolling behavior on mobile (allow overscroll)
  • Fix size and scrolling behavior of hamburger menu (no longer exceeds viewport)
  • Basic drop shadow for hamburger menu
  • Fix viewport parameters for mobile (prevents viewport problems from creating stuck pages)
  • In honor of International Box-Sizing Awareness Day set border-box style which I find more intuitive.

Screenshots (slightly larger than window to be able to compare header size)

screenshot from 2019-01-31 10-14-28

screenshot from 2019-01-31 10-15-20

screenshot from 2019-01-31 10-23-04

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 31, 2019
@coveralls
Copy link

coveralls commented Jan 31, 2019

Coverage Status

Coverage remained the same at 93.966% when pulling 3baf68b on style-refresh into 5a4308d on master.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming that we are properly importing Roboto from somewhere

box-sizing: border-box;
}

*, *:before, *:after {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems somewhat drastic to change every element to box sizing. From very brief googling (https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/) this does seem like a thing that people do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Doing this seemed to make correcting some alignment problems for mobile a lot easier.

margin-right: 20px;
}
/* end for layout */

body {
-webkit-text-size-adjust: 100%;
overflow-x: hidden;
font-family: "Source Sans Pro", sans-serif;
font-family: roboto, sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For similarity with below, Roboto (note the case)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're already importing Roboto from somewhere?

I see the import of Source Code Pro and the material icons font, but not of Roboto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roboto is a builtin as discussed offline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed capitalization.

Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll probably update styles again before May, just FYI. (It never stops!)

@kevmoo kevmoo deleted the style-refresh branch April 25, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a facelift to dartdoc
5 participants