Add manually-specified source code links to code #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated icon based on feedback from @kwalrath. The rest of Dart/Flutter does not yet use material, but until then, |
devoncarew
approved these changes
Jan 30, 2019
lib/src/model.dart
Outdated
| @@ -3215,6 +3216,15 @@ abstract class ModelElement extends Canonicalization | |||
| return _documentationFrom; | |||
| } | |||
|
|
|||
| bool get hasSourceHref => sourceHref != ''; | |||
lib/src/model.dart
Outdated
| bool get hasSourceHref => sourceHref != ''; | ||
| String _sourceHref; | ||
| String get sourceHref { | ||
| if (_sourceHref == null) { |
There was a problem hiding this comment.
_sourceHref ??= new SourceLinker.fromElement(this).href(); ?
|
Added an example and set it up to work for dartdoc itself when it gets published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1454 and #1892. This adds a material icon for a source code link and calculates relative paths to insert into a link template specified by the user in a dartdoc_options.yaml file or on the command line. Verified the alignment in mobile and normal usage.