Minimize number of tool execution runs #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (_libraryDocs == null) { | ||
| _libraryDocs = _setCanonicalFor(super.documentation); | ||
| // TODO(jcollins-g): warn if a macro/tool _does_ generate an unexpected | ||
| // canonicalFor? |
There was a problem hiding this comment.
Yeah, that's a good idea.
There was a problem hiding this comment.
It didn't seem super urgent so I didn't bother here, but in the long run...
pq
approved these changes
Jan 11, 2019
jcollins-g
added a commit
that referenced
this pull request
Jan 11, 2019
* canonicalFor must be declared literally in the library * Add tests for minimizing tool execution * dartfmt * Workaround problem with mixins on 2.1.0 stable * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
@canonicalForno longer able to be detected from macros or tools, but in so doing restrict tool executions to only documentation that will be used (dartdoc-canonical ModelElement instances, or ModelElements that have no canonicalization).As an aside, this seems to improve dartdoc's overall performance on flutter by about 15%.