Fix many mobile issues with dartdoc #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
reviewed
Dec 18, 2018
There was a problem hiding this comment.
Not being fluent here, I have to ask a probably obvious question... In the description, you suggest that this is a mobile-only fix but this looks more general? (That is, I'm not seeing any obvious "mobile-only" selectors.) I'm guessing it's something right in front of me I'm not seeing?
|
The mobile support and the small screen support is basically the same thing in dartdoc. So the selectors are on screen size (width, to be specific). I've rationalized them a bit too in this PR so it is a bit more consistent. |
|
Ah. That makes sense. Thanks for the clarification! |
pq
approved these changes
Dec 18, 2018
devoncarew
approved these changes
Dec 18, 2018
This was referenced Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908, #1048, #1348, and #1469. (Some minor bits of these were obsolete before this PR, so technically this doesn't fix everything listed. But I believe this cleans up enough to address the main points of these bugs and will address other mobile issues separately.)
This PR adds a mobile-only search box to the hamburger button. Also, this puts the navigation information usually in the title bar in there directly below the search, fixing a host of problems where you can't really get around the API documentation in mobile.
Screenshots for what flutter docs hamburger button menu now looks like: