Skip to content

Enable flutter plugin test #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ dart:
- stable
- "dev/raw/latest"
env:
- DARTDOC_BOT=flutter
- DARTDOC_BOT=sdk-analyzer
- DARTDOC_BOT=main
- DARTDOC_BOT=flutter
- DARTDOC_BOT=packages
- DARTDOC_BOT=sdk-docs
script: ./tool/travis.sh
Expand Down
4 changes: 1 addition & 3 deletions test/compare_output_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ void main() {
'Top level package requires Flutter but FLUTTER_ROOT environment variable not set|test_package_flutter_plugin requires the Flutter SDK, version solving failed')));
expect(result.stderr, isNot(contains('asynchronous gap')));
expect(result.exitCode, isNot(0));
},
skip:
true /* TODO(gspencer): Re-enable as soon as Flutter's config is sane again. */);
});

test("Validate --version works", () async {
var args = <String>[dartdocBin, '--version'];
Expand Down
1 change: 1 addition & 0 deletions testing/test_package_flutter_plugin/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
android/**
10 changes: 8 additions & 2 deletions tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,7 @@ Future<void> serveFlutterDocs() async {
}

@Task('Validate flutter docs')
// TODO(jcollins-g): add buildDartdocFlutterPluginDocs once passing
@Depends(buildFlutterDocs)
@Depends(buildFlutterDocs, buildDartdocFlutterPluginDocs)
void validateFlutterDocs() {}

@Task('Build flutter docs')
Expand Down Expand Up @@ -641,6 +640,11 @@ class FlutterRepo {
['precache'],
workingDirectory: flutterPath,
);
await launcher.runStreamed(
bin,
['update-packages'],
workingDirectory: flutterPath,
);
}

factory FlutterRepo.fromPath(String flutterPath, Map<String, String> env,
Expand Down Expand Up @@ -924,6 +928,8 @@ Future<WarningsCollection> _buildDartdocFlutterPluginDocs() async {
[
'--enable-asserts',
pathLib.join(Directory.current.path, 'bin', 'dartdoc.dart'),
'--exclude-packages',
'Dart', // TODO(jcollins-g): dart-lang/dartdoc#1431
'--json',
'--link-to-remote',
'--output',
Expand Down