Skip to content

Print exit code when throwing process exception #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

Print exit code when throwing process exception #1788

merged 1 commit into from
Oct 10, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Oct 9, 2018 •
edited
Loading

Another attempt to add debugging information to catch #1770. This should enable us to find out whether the subprocess died due to signal, at least.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 9, 2018
@jcollins-g jcollins-g requested a review from devoncarew October 9, 2018 20:36
@jcollins-g jcollins-g merged commit 39fad72 into master Oct 10, 2018
@jcollins-g jcollins-g mentioned this pull request Oct 15, 2018
Closed
@jcollins-g jcollins-g deleted the exit-code-print branch November 27, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @devoncarew @googlebot