Prepare for 0.20.2 and fix void problems #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added some minor tweaks post-merge to minimize the number of packages we still depend on that don't have updated upper bounds. |
|
@MichaelRFairhurst PTAL post merge? |
devoncarew
approved these changes
Jul 24, 2018
lib/dartdoc.dart
Outdated
| void logAnalysisErrors(Set<Source> sources) async { | ||
| List<AnalysisErrorInfo> errorInfos = []; | ||
| Future<void> logAnalysisErrors(Set<Source> sources) async { | ||
| List<AnalysisErrorInfo> errorInfos = <AnalysisErrorInfo>[]; |
There was a problem hiding this comment.
The right hand side should be inferred; I generally specify the LHS and let the RHS float, but YMMV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724 and another part of #1728, and updates the analyzer package to the latest version.