Skip to content

Move SDK library expectation to all subcategories #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2018
Merged

Move SDK library expectation to all subcategories #1713

merged 2 commits into from
Jun 13, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Jun 13, 2018 •
edited
Loading

Fixes #1712, handling new Core category introduced in .61. Also corrects for retype having been removed in .62.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jun 13, 2018
@jcollins-g jcollins-g requested review from devoncarew and pq June 13, 2018 19:50
pq
pq approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit 7430e1c into master Jun 13, 2018
@jcollins-g jcollins-g deleted the fix-sanity-check branch June 13, 2018 21:16
@jcollins-g jcollins-g mentioned this pull request Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

@devoncarew devoncarew Awaiting requested review from devoncarew

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @pq @googlebot