Skip to content

Prepare for 0.20.0 #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 30, 2018
Merged

Prepare for 0.20.0 #1702

merged 10 commits into from
May 30, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented May 29, 2018

Fixes #1668. Fix --help, enable previously blocked tests, and require .59 for Dart 2.0.

--help was crashing in --preview-dart-2 because we passed in a null for hide when we should have been passing in false. Also enabled all the tests blocked previously by dart-lang/sdk#32901.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label May 29, 2018
@jcollins-g jcollins-g changed the title WIP: Try dart2 with fix for sdk bug Fix --help, enable previously blocked tests, and require .59 for Dart 2.0 May 30, 2018
@jcollins-g jcollins-g changed the title Fix --help, enable previously blocked tests, and require .59 for Dart 2.0 Prepare for 0.20.0 May 30, 2018
@jcollins-g jcollins-g requested review from devoncarew and pq and removed request for devoncarew May 30, 2018 15:17
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g merged commit 17e8b80 into master May 30, 2018
@jcollins-g jcollins-g deleted the windows-dart2 branch May 30, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants