Fix bug where --version didn't do anything #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
May 11, 2018
bin/dartdoc.dart
Outdated
| void _printUsageAndExit(ArgParser parser, {int exitCode: 0}) { | ||
| print('Usage: dartdoc [OPTIONS]\n'); | ||
| print(parser.usage); | ||
| exit(exitCode); | ||
| } | ||
|
|
||
| /// Print version information. | ||
| void _printVersionAndExit(ArgParser parser, {int exitCode: 0}) { |
There was a problem hiding this comment.
is exitCode ever passed in by clients?
lib/dartdoc.dart
Outdated
| @@ -11,6 +11,7 @@ library dartdoc; | |||
| import 'dart:async'; | |||
| import 'dart:convert'; | |||
| import 'dart:io'; | |||
| import 'dart:mirrors'; | |||
There was a problem hiding this comment.
leftover from an attempt to automatically read the version number from pubspec.yaml.
| @@ -67,7 +67,7 @@ Future<FlutterRepo> get cleanFlutterRepo async { | |||
| await cleanFlutterDir.parent.create(recursive: true); | |||
| assert(_lockFuture == null); | |||
| _lockFuture = new File(pathLib.join(cleanFlutterDir.parent.path, 'lock')) | |||
| .openSync(mode: FileMode.WRITE) | |||
| .openSync(mode: FileMode.write) | |||
There was a problem hiding this comment.
This will mean that dartdoc can only run on the very very latest sdk; you might want to just live with deprecation warnings for a while.
There was a problem hiding this comment.
There are enough other times I've done this that it probably is already required; updated minimums on pubspec.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1692.