Prefer package-local canonicalization and warn on reexported private API across packages #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
May 2, 2018
| testDartdocFlutterPlugin() async { | ||
| WarningsCollection warnings = await _buildDartdocFlutterPluginDocs(); | ||
| if (!warnings.warningKeyCounts.isEmpty) { |
There was a problem hiding this comment.
Perhaps add a warnings.hasWarnings getter?
There was a problem hiding this comment.
since we're referencing warningKeyCounts to print it immediately after this, I think it's clearer to not have an extra getter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small bug in canonicalization when cross-linking packages, where we sometimes might pick the wrong package as canonical when reexporting is going on. Provide a specific warning if a reexport of private APIs makes canonicalization unreliable.