-
Notifications
You must be signed in to change notification settings - Fork 125
Support flutter in cross-links and add tests #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2d006e9
Ready.
jcollins-g 2826c6e
Fix case when FLUTTER_ROOT is not set
jcollins-g 95aa389
deletes throw if target does not exist
jcollins-g b970268
Get rid of infinite recursion in some cases for option handling
jcollins-g 2d15b69
Fix grinder stream handling to not chop off error messages
jcollins-g aba4530
Can't seem to get any information for failure, so hack travis script
jcollins-g e584f10
reduce parallelism
jcollins-g d682e3d
Disable parallelization on travis for testing
jcollins-g d19951c
Use numberOfProcessors
jcollins-g f0e3afe
Travis has two processors and may not be detected properly by dart
jcollins-g 12be1cf
print processors and adjust to two cores for travis
jcollins-g 13d425e
Fix travis parallelization once and for all.
jcollins-g 9e2c427
Fix MultiFutureTracker parallelism restriction
jcollins-g ad38288
Review comments and analyzer exclude for flutter package (ok that it …
jcollins-g 7e0fc4a
Redo flutter repo build to fix reentrancy problems
jcollins-g 328e1c5
Use a Completer
jcollins-g abaaeb5
Merge branch 'master' into linking-refinements
jcollins-g 9d8c6b2
dartfmt
jcollins-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,4 @@ branches: | |
cache: | ||
directories: | ||
- $HOME/.pub-cache | ||
- $HOME/.dartdoc_grinder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style question: since you're creatine an instance here, I'd have expected a named factory constructor instead of a static; any reason for that?
EDIT: like
withoutGenerators(..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asynchronous factory (or normal) constructors don't work in Dart. dart-lang/sdk#23115
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, right! I didn't notice the
await
. Thanks for clarifying. 👍