Refactor DartdocConfig option usage, part 4 of 4 #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2018
pq
approved these changes
Apr 19, 2018
lib/src/model.dart
Outdated
|
|
||
| Map<String, Map<String, dynamic>> __crossdartJson; | ||
| // TODO(jcollins-g): move to [Package] | ||
| Map<String, Map<String, dynamic>> get crossdartJson { | ||
| if (__crossdartJson == null) { | ||
| // TODO(jcollins-g): allow crossdart.json location to be configurable | ||
| var crossdartFile = | ||
| new File(pathLib.join(config.inputDir.path, "crossdart.json")); | ||
| new File(pathLib.join(config.inputDir, "crossdart.json")); |
lib/src/model.dart
Outdated
| @@ -5000,7 +5007,7 @@ abstract class SourceCodeMixin implements Documentable { | |||
| } | |||
| } else if (uri.startsWith("dart:")) { | |||
lib/src/model.dart
Outdated
| @@ -5000,7 +5007,7 @@ abstract class SourceCodeMixin implements Documentable { | |||
| } | |||
| } else if (uri.startsWith("dart:")) { | |||
| var packageName = "sdk"; | |||
| var packageVersion = config.sdkVersion; | |||
lib/src/model.dart
Outdated
| } | ||
| return _sdk; | ||
| } | ||
|
|
||
| EmbedderSdk _embedderSdk; | ||
| EmbedderSdk get embedderSdk { | ||
| if (_embedderSdk == null && packageMeta.isSdk == false) { | ||
| if (_embedderSdk == null && config.packageMeta.isSdk == false) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609. And finally, the payoff. Eliminate the old dartdoc config classes, seriously clean up
bin/dartdoc.dart, define options a little more closely to where they are used, and make it at least not completely arcane to build your own generators in dartdoc extensions.This implements, but doesn't finalize #1674. I'm going to write a series of integration tests for each new option and promote them to supported once I'm convinced they work reliably from config files, but that's an awful lot to throw into this PR, too.