Eliminate relative imports where possible and workaround inheritance problem in reexported classes #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
changed the title
pq
approved these changes
Apr 18, 2018
lib/dartdoc.dart
Outdated
| export 'src/generator.dart'; | ||
| export 'src/model.dart'; | ||
| export 'src/package_meta.dart'; | ||
| import 'package:dartdoc/src/config.dart'; |
There was a problem hiding this comment.
Consider re-ordering alphabetically?
FWIW IDEA makes this a snap w/ the "Optimize Imports..." action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative imports when mixed with absolute imports can produce inconsistent analysis results, confusing Dartdoc and its tests. Fix dartdoc's own use of imports internally to prevent this from being a possible issue.
Also add a workaround for dart-lang/sdk#32923, making sure that we calculate inheritance using the defining library.