Fix lints and warnings accumulated in dartdoc #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Mar 15, 2018
kevmoo
reviewed
Mar 15, 2018
| @@ -7,7 +7,7 @@ homepage: https://github.com/dart-lang/dartdoc | |||
| # For development, recommend 1.25.0-dev.0.0 or higher to allow | |||
| # dartanalyzer to work on dartdoc itself. | |||
| environment: | |||
| sdk: '>=1.23.0-dev.11.5 <2.0.0' | |||
| sdk: '>=2.0.0-dev.9.0 <3.0.0' | |||
There was a problem hiding this comment.
This constraint is handy to know. Thanks!
pq
approved these changes
Mar 16, 2018
| @@ -7,7 +7,7 @@ homepage: https://github.com/dart-lang/dartdoc | |||
| # For development, recommend 1.25.0-dev.0.0 or higher to allow | |||
| # dartanalyzer to work on dartdoc itself. | |||
| environment: | |||
| sdk: '>=1.23.0-dev.11.5 <2.0.0' | |||
| sdk: '>=2.0.0-dev.9.0 <3.0.0' | |||
There was a problem hiding this comment.
This constraint is handy to know. Thanks!
| @@ -224,6 +221,7 @@ typedef int LotsAndLotsOfParameters(so, many, parameters, it, should, wrap, | |||
|
|
|||
| /// This class is cool! | |||
| class Cool { | |||
| // ignore: missing_return | |||
| Cool returnCool() {} | |||
There was a problem hiding this comment.
Aside: why not just return null? In general, I'm curious why all the ignores and not just fixes?
There was a problem hiding this comment.
The test package is intended to be a bit strange, using outdated, error-prone and/or obsolete constructions in some places. So I don't want to accidentally make the test package too "clean".
I shouldn't be doing that anywhere outside testing/ though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most are due to recent library changes, but the rest have just been building up in dartdoc for a long time. This cleans them up.