Skip to content

Serve test package docs through grinder #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 4, 2018
Merged

Conversation

jcollins-g
Copy link
Contributor

The test package is useful for trying things out and demoing them as docs build much faster for them.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 22, 2017
if (label == null) label = '';
if (label != '') label = '-$label';
var launcher = new SubprocessLauncher('build-test-package-docs$label');
await launcher.runStreamed(sdkBin('pub'), ['get'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a grinder shorthand for sdkBin('pub') (but don't recall what it is).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed (a class named Pub). However grind's shorthands don't allow me to have the control I want for how they are executed. I've found it frustrating to debug a series of fork-execs that is partially hidden by "shorthands" that look like they aren't fork/execs. This way, I can see exactly what it is doing both in the output of grinder and in the source code.

if (label == null) label = '';
if (label != '') label = '-$label';
var launcher = new SubprocessLauncher('build-test-package-docs$label');
await launcher.runStreamed(sdkBin('pub'), ['get'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed (a class named Pub). However grind's shorthands don't allow me to have the control I want for how they are executed. I've found it frustrating to debug a series of fork-execs that is partially hidden by "shorthands" that look like they aren't fork/execs. This way, I can see exactly what it is doing both in the output of grinder and in the source code.

tool/grind.dart Outdated
@Depends(buildTestPackageDocs)
Future serveTestPackageDocs() async {
log('launching dhttpd on port 8002 for SDK');
var launcher = new SubprocessLauncher('serve-sdk-docs');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this string is wrong, changed.

@jcollins-g jcollins-g merged commit f5da1f2 into master Jan 4, 2018
@kevmoo kevmoo deleted the serve-test-package-docs branch January 11, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants