Add a deep collection comparison to memoizer in checked mode #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jan 2, 2018
lib/src/model_utils.dart
Outdated
| /// memoized function is unchanging using [DeepCollectionEquality]. Still | ||
| /// returns the cached value assuming the assertion passes. | ||
| class ValidatingMemoizer extends Memoizer { | ||
| bool _assert_on_difference; |
| /// Otherwise, a wrapper around putIfAbsent. | ||
| @override | ||
| R _cacheIfAbsent<R>(_HashableList key, R Function() f) { | ||
| if (_assert_on_difference) { |
There was a problem hiding this comment.
w/o the init at definition, this will be if (null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class, ValidatingMemoizer, that in checked mode adds an assert to validate that cached values haven't changed from the return value of f(). There are many areas of dartdoc where these values changing are a sign of underlying bugs. This way we can make use of the cache to verify these.