Add automatic SDK warning comparison between versions to dartdoc #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oizer+flutter_auto_integrate
devoncarew
approved these changes
Dec 15, 2017
| } | ||
|
|
||
| /// Output formatter for comparing warnings. | ||
| String printWarningDelta(String title, String dartdocOriginalBranch, |
There was a problem hiding this comment.
It's "public" so it can be imported by grinder. It's not public in another sense, that being it is under lib/src.
| Map<String, int> original, Map<String, int> current) { | ||
| StringBuffer printBuffer = new StringBuffer(); | ||
| Set<String> quantityChangedOuts = new Set(); | ||
| Set<String> onlyOriginal = new Set(); |
There was a problem hiding this comment.
I think you can calculate these using Set.difference()?
There was a problem hiding this comment.
I could, but I would have to build more sets and then throw them away to do so. Map.keys is an iterable, not a set. Since I have to traverse by hand once anyway since "quantityChangedOuts" isn't something computable by difference, it seemed reasonable to do so for all three and save the throwaway Sets.
| /// Version of dartdoc we should use when making comparisons. | ||
| String get dartdocOriginalBranch { | ||
| String branch = 'master'; | ||
| if (Platform.environment.containsKey('DARTDOC_ORIGINAL')) { |
There was a problem hiding this comment.
warn (or log?) when pulling from an env variable, so people remember they've set it?
…oizer+sdk_warnings_compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new grind target, compare-sdk-warnings, that will take the version of dartdoc in the CWD and compare it running against the same SDK to another version specified by git branch or tag in the environment variable DARTDOC_ORIGINAL. Moves _SubprocessLauncher out into io_utils and adds json parsing support to it for the warning comparison.