Allow mixins that call super #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Dec 1, 2017
| @@ -2,6 +2,7 @@ analyzer: | |||
| strong-mode: true | |||
| language: | |||
| enableGenericMethods: true | |||
| enableSuperMixins: true | |||
There was a problem hiding this comment.
Are we using this feature in the dartdoc codebase? I'm curious why you're turning it on here...
There was a problem hiding this comment.
#1541 -- A flutter user tried to do this. Flutter could be using it in their codebase -- it is enabled in their analysis options -- but I guess they just haven't yet or otherwise dartdoc wouldn't have worked for them.
There was a problem hiding this comment.
Oh, nvm, you mean why in analysis_options.yaml. The test code has this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1541.
Add an analysis option to allow super-mixins, and a class in fake.dart to verify that dartdoc doesn't quit with an analysis error when encountering them.