Skip to content

HtmlGeneratorInstance: cleanup JSON writing #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2017
Merged

HtmlGeneratorInstance: cleanup JSON writing #1536

merged 1 commit into from
Nov 6, 2017

Conversation

@kevmoo
Copy link
Member

@kevmoo kevmoo commented Nov 3, 2017 •
edited
Loading

  • Call sort separately – given how long the map call is, it's tough to interpret the toList()..sort(...)
  • Use the existing _writeFile helper

Related to #1537

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 3, 2017
@kevmoo kevmoo merged commit b159cdc into master Nov 6, 2017
@kevmoo kevmoo deleted the cleanup_json_index_writing branch November 6, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devoncarew devoncarew Awaiting requested review from devoncarew

1 more reviewer

@jcollins-g jcollins-g jcollins-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevmoo @jcollins-g @googlebot