Skip to content

Fix blocking issues related to flutter #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 20, 2017
Merged

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Sep 19, 2017

Fixes #1478:

  • Eliminate excessive stack depth on link checker which occasionally caused stack overflows.
  • Use preferredClass in more cases to disambiguate doc links (fixes problems with checked mode)
  • Add basic support, and tests for MultiplyInheritedExecutableElements when they come from the analyzer.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Sep 19, 2017
return null;
}
visited.add(fullPath);
Iterable<String> stringLinks = stringLinksAndHref.item1;
String baseHref = stringLinksAndHref.item2;

// Prevent extremely large stacks by storing the paths we are using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk, good to document this (why we're using this algorithm)

@jcollins-g jcollins-g merged commit ca63c71 into master Sep 20, 2017
@jcollins-g jcollins-g deleted the field-flutter-misc branch September 20, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dartdoc build is failing
3 participants